Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854Ab0LQDnv (ORCPT ); Thu, 16 Dec 2010 22:43:51 -0500 Received: from void.printf.net ([89.145.121.20]:37482 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685Ab0LQDnt (ORCPT ); Thu, 16 Dec 2010 22:43:49 -0500 Date: Fri, 17 Dec 2010 03:43:42 +0000 From: Chris Ball To: Philip Rakity Cc: Takashi Iwai , Aries Lee , zhangfei gao , Qiming Wu , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mmc: Test bus-width for old MMC devices (v2) Message-ID: <20101217034342.GA19673@void.printf.net> References: <20101216234032.GA17239@void.printf.net> <50D31EC8-BD9E-4920-8CEB-2AD10DF9C5C5@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50D31EC8-BD9E-4920-8CEB-2AD10DF9C5C5@marvell.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 955 Lines: 29 Hi Philip, On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote: > It is not possible for bus_width to be not initialized. This would imply ARRAY_SIZE(bus_widths) is 1. Certainly not true. Right, I agree. We should fix the warning anyway. > We could just initialize by changing > + unsigned idx, bus_width; > to > + unsigned idx, bus_width = 0; Okay, I've pushed to mmc-next with that change. > I wonder what compiler are you using so we can avoid this issue in future. Ah, good point -- I was building with a gcc 4.1.2 ARM cross-compiler, and using a gcc 4.5.1 cross-build instead avoids the warning. Thanks, -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/