Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941Ab0LQG2i (ORCPT ); Fri, 17 Dec 2010 01:28:38 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:49418 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841Ab0LQG2g convert rfc822-to-8bit (ORCPT ); Fri, 17 Dec 2010 01:28:36 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=kCiuSATsSxgarbmTA8bIfL67aZtTdzpUUr8m2zUCbObiWE1IvdLGEljDIEqnfcsnlJ mUeU/N1aEQjJDvSfgH25V0tly90avtLGaVYcBmNXVLPNL6TyMACcH0WAfdf9cCJ1gMzt 3Ztigf3ly4fi8IAvlYEmeNk+Z+LeUwFWAbqi8= MIME-Version: 1.0 In-Reply-To: References: <4d0662e511688484b3@agluck-desktop.sc.intel.com> Date: Thu, 16 Dec 2010 22:28:35 -0800 Message-ID: Subject: Re: [concept & "good taste" review] persistent store From: Tony Luck To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu, greg@kroah.com, akpm@linux-foundation.org, ying.huang@intel.com, Borislav Petkov , David Miller , Alan Cox , Jim Keniston , Kyungmin Park , Geert Uytterhoeven , "H. Peter Anvin" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 27 On Thu, Dec 16, 2010 at 5:57 PM, Linus Torvalds wrote: > Then I hit the > > ? ? ? ?/* Don't dump oopses to persistent store */ > ? ? ? ?if (reason == KMSG_DUMP_OOPS) > ? ? ? ? ? ? ? ?return; > > and I'm like "ok, this is just stupid". > > The _only_ valid reason for persistent storage is for things like > oopses that kill the machine. Maybe I misunderstood what "KMSG_DUMP_OOPS" meant ... it looked to me like this code is used for non-fatal OOPsen - ones that will be logged to /var/log/messages. You are right that the whole point of this is to save data from fatal errors ... if I'm not doing that, then I'm happy to change things until I achieve that goal. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/