Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116Ab0LQKmn (ORCPT ); Fri, 17 Dec 2010 05:42:43 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:48888 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1749667Ab0LQKmm (ORCPT ); Fri, 17 Dec 2010 05:42:42 -0500 Subject: Re: [PATCH] regulator: Only notify voltage changes when they succeed From: Liam Girdwood To: Mark Brown Cc: Saravana Kannan , linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com In-Reply-To: <1292507950-8288-1-git-send-email-broonie@opensource.wolfsonmicro.com> References: <1292507950-8288-1-git-send-email-broonie@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 17 Dec 2010 10:42:27 +0000 Message-ID: <1292582547.3286.2.camel@odin> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 28 On Thu, 2010-12-16 at 13:59 +0000, Mark Brown wrote: > Currently we notify a voltage change whenever we exit set_voltage(), > even if the change failed for some reason (eg, a constraints issue). > This shouldn't cause any substantial ill effects but is wasteful as > listeners get notified on noops. Fix this by moving the notification > into _do_set_voltage() and only notifying if we don't return an error. > > Reported-by: Saravana Kannan > Signed-off-by: Mark Brown > --- > drivers/regulator/core.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/