Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753781Ab0LQKtH (ORCPT ); Fri, 17 Dec 2010 05:49:07 -0500 Received: from goliath.siemens.de ([192.35.17.28]:17889 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714Ab0LQKtG (ORCPT ); Fri, 17 Dec 2010 05:49:06 -0500 Message-ID: <4D0B400D.8010903@siemens.com> Date: Fri, 17 Dec 2010 11:48:45 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Thomas Gleixner CC: Jan Kiszka , Avi Kivity , Marcelo Tosatti , "linux-kernel@vger.kernel.org" , kvm , Tom Lyon , Alex Williamson , "Michael S. Tsirkin" Subject: Re: [PATCH v3 2/4] genirq: Inform handler about line sharing state References: <4D0A75E3.3090900@web.de> <4D0B1CD9.5060601@web.de> <4D0B3C11.4090307@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 26 Am 17.12.2010 11:41, Thomas Gleixner wrote: > On Fri, 17 Dec 2010, Jan Kiszka wrote: >> Am 17.12.2010 11:23, Thomas Gleixner wrote: >>> OTOH, if we have to disable anyway, then we could simply keep it >>> disabled across the installation of a new handler. That would make the >>> notification business go away, wouldn't it ? >> >> No, the notification is still necessary in case the registered handler >> keeps the line off after returning from both hard and threaded handler. > > And how should that happen? If it is in oneshot mode then the line is > reenabled when the thread handler returns. disable_irq_nosync is called by the handler before returning. And it's the handler's job to revert this, properly synchronizing it internally. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/