Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757063Ab0LSMzt (ORCPT ); Sun, 19 Dec 2010 07:55:49 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:38633 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756557Ab0LSMzp (ORCPT ); Sun, 19 Dec 2010 07:55:45 -0500 From: "Rafael J. Wysocki" To: Matthew Wilcox Subject: Re: [PATCH] PCI / PCIe: Clear Root PME Status bits during early resume Date: Sun, 19 Dec 2010 13:54:47 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc6+; KDE/4.4.4; x86_64; ; ) Cc: linux-pci@vger.kernel.org, Jesse Barnes , Matthew Garrett , ACPI Devel Maling List , LKML , "Linux-pm mailing list" References: <201012191149.40547.rjw@sisk.pl> <201012191338.24070.rjw@sisk.pl> <201012191341.23601.rjw@sisk.pl> In-Reply-To: <201012191341.23601.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012191354.47960.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 29 On Sunday, December 19, 2010, Rafael J. Wysocki wrote: > On Sunday, December 19, 2010, Rafael J. Wysocki wrote: > > On Sunday, December 19, 2010, Matthew Wilcox wrote: > > > On Sun, Dec 19, 2010 at 11:49:40AM +0100, Rafael J. Wysocki wrote: > > > > in pci_pm_default_resume_early() and not in the port's resume > > > > routine, because it's generally necessary even if the PCI Express > > > > port driver is not used). > > > > > > We should make it impossible to not use the PCIe port driver. > > > > Actually, that's not correct. In some cases (e.g. _OSI doesn't allow us > > That should have been _OSC(), sorry. > > > to use PCIe native services), we simply can't use it (because it is unsafe > > and leads to serious problems). Well, in fact, scratch that. We can make it do nothing except for an early resume routine doing the clearing of the Root PME Status bit in that cases. I'll rework the patch in that direction. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/