Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757482Ab0LTMMV (ORCPT ); Mon, 20 Dec 2010 07:12:21 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:48450 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757366Ab0LTMMT (ORCPT ); Mon, 20 Dec 2010 07:12:19 -0500 Date: Mon, 20 Dec 2010 12:12:16 +0000 From: Mark Brown To: Paul Mundt Cc: Stephen Rothwell , Samuel Ortiz , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Sundar Iyer , Linus Walleij Subject: Re: linux-next: manual merge of the mfd tree with the ux500-core tree Message-ID: <20101220121215.GC26706@rakim.wolfsonmicro.main> References: <20101220152148.6fedee0d.sfr@canb.auug.org.au> <20101220042344.GB10050@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101220042344.GB10050@linux-sh.org> X-Cookie: Reapply as necessary. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 31 On Mon, Dec 20, 2010 at 01:23:44PM +0900, Paul Mundt wrote: > On Mon, Dec 20, 2010 at 03:21:48PM +1100, Stephen Rothwell wrote: > > -static void tc3589x_irq_dummy(unsigned int irq) > > +static void tc3589x_irq_dummy(struct irq_data *data) > > { > > /* No mask/unmask at this level */ > > } > > > > static struct irq_chip tc3589x_irq_chip = { > > - .name = "tc3589x", > > - .mask = tc3589x_irq_dummy, > > - .unmask = tc3589x_irq_dummy, > > + .name = "tc3589x", > > + .irq_mask = tc3589x_irq_dummy, > > + .irq_unmask = tc3589x_irq_dummy, > > }; > > static int tc3589x_irq_init(struct tc3589x *tc3589x) > Is there some reason you don't just kill this off and use dummy_irq_chip? Mainly that I didn't take the time to read through the code and figure out if it was doing anything interesting with the struct elsewhere which meant this was actually sensible (one of the other drivers was doing something surprising). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/