Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757428Ab0LTMfV (ORCPT ); Mon, 20 Dec 2010 07:35:21 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:36621 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756919Ab0LTMfT convert rfc822-to-8bit (ORCPT ); Mon, 20 Dec 2010 07:35:19 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=aM5Wjz8sjCKPP1q/PKb1eTNbnE2WM+jBolZ6mWs6VdMbSwFmew9sCTtROnRmtrms0t JGKuM2dhqYyrU/L5LNuFojmtYt94iXVM/2jLrvmWHa8QImuRiiFpxFfyICm2et/KP3nu iBC0J0vVvNVR2nBrmsOUIsOn4yGna/OUxizio= MIME-Version: 1.0 In-Reply-To: <1292842127-21406-10-git-send-email-s.hauer@pengutronix.de> References: <1292842127-21406-1-git-send-email-s.hauer@pengutronix.de> <1292842127-21406-10-git-send-email-s.hauer@pengutronix.de> Date: Mon, 20 Dec 2010 20:35:18 +0800 Message-ID: Subject: Re: [PATCH 9/9] ARM i.MX51 babbage: Add framebuffer support From: arden jay To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel Ortiz , liu.y.victor@gmail.com, B02280@freescale.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5616 Lines: 158 Hi Sascha, 2010/12/20 Sascha Hauer : > Signed-off-by: Sascha Hauer > --- > ?arch/arm/mach-mx5/Kconfig ? ? ? ? ? ? ?| ? ?1 + > ?arch/arm/mach-mx5/board-mx51_babbage.c | ? 74 ++++++++++++++++++++++++++++++++ > ?2 files changed, 75 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig > index 5011f42..2a936b7 100644 > --- a/arch/arm/mach-mx5/Kconfig > +++ b/arch/arm/mach-mx5/Kconfig > @@ -22,6 +22,7 @@ config MACH_MX51_BABBAGE > ? ? ? ?select IMX_HAVE_PLATFORM_IMX_UART > ? ? ? ?select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX > ? ? ? ?select IMX_HAVE_PLATFORM_SPI_IMX > + ? ? ? select IMX_HAVE_PLATFORM_IMX_IPUV3 > ? ? ? ?help > ? ? ? ? ?Include support for MX51 Babbage platform, also known as MX51EVK in > ? ? ? ? ?u-boot. This includes specific configurations for the board and its > diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c > index 368a315..6c1576c 100644 > --- a/arch/arm/mach-mx5/board-mx51_babbage.c > +++ b/arch/arm/mach-mx5/board-mx51_babbage.c > @@ -22,11 +22,13 @@ > ?#include > ?#include > ?#include > +#include > > ?#include > ?#include > ?#include > ?#include > +#include > Why it needs imx-ipu-v3.h and ipu-v3.h? > ?#include > ?#include > @@ -158,6 +160,41 @@ static iomux_v3_cfg_t mx51babbage_pads[] = { > ? ? ? ?MX51_PAD_CSPI1_SCLK__ECSPI1_SCLK, > ? ? ? ?MX51_PAD_CSPI1_SS0__GPIO_4_24, > ? ? ? ?MX51_PAD_CSPI1_SS1__GPIO_4_25, > + > + ? ? ? /* Display */ > + ? ? ? MX51_PAD_DISPB2_SER_DIN__GPIO_3_5, > + ? ? ? MX51_PAD_DISPB2_SER_DIO__GPIO_3_6, > + ? ? ? MX51_PAD_NANDF_D12__GPIO_3_28, > + > + ? ? ? MX51_PAD_DISP1_DAT0__DISP1_DAT0, > + ? ? ? MX51_PAD_DISP1_DAT1__DISP1_DAT1, > + ? ? ? MX51_PAD_DISP1_DAT2__DISP1_DAT2, > + ? ? ? MX51_PAD_DISP1_DAT3__DISP1_DAT3, > + ? ? ? MX51_PAD_DISP1_DAT4__DISP1_DAT4, > + ? ? ? MX51_PAD_DISP1_DAT5__DISP1_DAT5, > + ? ? ? MX51_PAD_DISP1_DAT6__DISP1_DAT6, > + ? ? ? MX51_PAD_DISP1_DAT7__DISP1_DAT7, > + ? ? ? MX51_PAD_DISP1_DAT8__DISP1_DAT8, > + ? ? ? MX51_PAD_DISP1_DAT9__DISP1_DAT9, > + ? ? ? MX51_PAD_DISP1_DAT10__DISP1_DAT10, > + ? ? ? MX51_PAD_DISP1_DAT11__DISP1_DAT11, > + ? ? ? MX51_PAD_DISP1_DAT12__DISP1_DAT12, > + ? ? ? MX51_PAD_DISP1_DAT13__DISP1_DAT13, > + ? ? ? MX51_PAD_DISP1_DAT14__DISP1_DAT14, > + ? ? ? MX51_PAD_DISP1_DAT15__DISP1_DAT15, > + ? ? ? MX51_PAD_DISP1_DAT16__DISP1_DAT16, > + ? ? ? MX51_PAD_DISP1_DAT17__DISP1_DAT17, > + ? ? ? MX51_PAD_DISP1_DAT18__DISP1_DAT18, > + ? ? ? MX51_PAD_DISP1_DAT19__DISP1_DAT19, > + ? ? ? MX51_PAD_DISP1_DAT20__DISP1_DAT20, > + ? ? ? MX51_PAD_DISP1_DAT21__DISP1_DAT21, > + ? ? ? MX51_PAD_DISP1_DAT22__DISP1_DAT22, > + ? ? ? MX51_PAD_DISP1_DAT23__DISP1_DAT23, > +#define MX51_PAD_DI_GP4__IPU_DI2_PIN15 ? ? ? ? ? ? ? ? IOMUX_PAD(0x758, 0x350, 4, 0x0, ? 0, NO_PAD_CTRL) > + ? ? ? MX51_PAD_DI_GP4__IPU_DI2_PIN15, > + > + ? ? ? /* I2C DVI enable */ > + ? ? ? MX51_PAD_CSI2_HSYNC__GPIO_4_14, > ?}; > > ?/* Serial ports */ > @@ -346,6 +383,23 @@ static const struct spi_imx_master mx51_babbage_spi_pdata __initconst = { > ? ? ? ?.num_chipselect = ARRAY_SIZE(mx51_babbage_spi_cs), > ?}; > > +static struct ipuv3_fb_platform_data babbage_fb0_data = { > + ? ? ? .interface_pix_fmt = IPU_PIX_FMT_RGB24, > + ? ? ? .flags = IMX_IPU_FB_USE_MODEDB | IMX_IPU_FB_USE_OVERLAY, > + ? ? ? .display = 0, > +}; > + > +static struct ipuv3_fb_platform_data babbage_fb1_data = { > + ? ? ? .interface_pix_fmt = IPU_PIX_FMT_RGB565, > + ? ? ? .flags = IMX_IPU_FB_USE_MODEDB, > + ? ? ? .display = 1, > +}; > + > +static struct imx_ipuv3_platform_data ipu_data = { > + ? ? ? .fb_head0_platform_data = &babbage_fb0_data, > + ? ? ? .fb_head1_platform_data = &babbage_fb1_data, > +}; > + > ?/* > ?* Board specific initialization. > ?*/ > @@ -392,6 +446,26 @@ static void __init mxc_board_init(void) > ? ? ? ? ? ? ? ?ARRAY_SIZE(mx51_babbage_spi_board_info)); > ? ? ? ?imx51_add_ecspi(0, &mx51_babbage_spi_pdata); > ? ? ? ?imx51_add_imx2_wdt(0, NULL); > + > +#define GPIO_DVI_DETECT ? ? ? ?(2 * 32 + 28) > +#define GPIO_DVI_RESET (2 * 32 + 5) > +#define GPIO_DVI_PWRDN (2 * 32 + 6) > +#define GPIO_DVI_I2C ? (3 * 32 + 14) This should be in board-xxx.h. > + > + ? ? ? /* DVI Detect */ > + ? ? ? gpio_request(GPIO_DVI_DETECT, "dvi detect"); > + ? ? ? gpio_direction_input(GPIO_DVI_DETECT); > + ? ? ? /* DVI Reset - Assert for i2c disabled mode */ > + ? ? ? gpio_request(GPIO_DVI_RESET, "dvi reset"); > + ? ? ? gpio_direction_output(GPIO_DVI_RESET, 0); > + ? ? ? /* DVI Power-down */ > + ? ? ? gpio_request(GPIO_DVI_PWRDN, "dvi pwdn"); > + ? ? ? gpio_direction_output(GPIO_DVI_PWRDN, 1); > + > + ? ? ? gpio_request(GPIO_DVI_I2C, "dvi i2c"); > + ? ? ? gpio_direction_output(GPIO_DVI_I2C, 0); > + Can this implement as function, and passes to specified driver who needs it? > + ? ? ? imx51_add_ipuv3(&ipu_data); > ?} > > ?static void __init mx51_babbage_timer_init(void) > -- > 1.7.2.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > Please read the FAQ at ?http://www.tux.org/lkml/ > -- cheers, jay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/