Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757464Ab0LTNAL (ORCPT ); Mon, 20 Dec 2010 08:00:11 -0500 Received: from mga09.intel.com ([134.134.136.24]:16760 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750Ab0LTNAJ (ORCPT ); Mon, 20 Dec 2010 08:00:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.60,202,1291622400"; d="scan'208";a="688906697" Date: Mon, 20 Dec 2010 14:00:05 +0100 From: Samuel Ortiz To: Mark Brown Cc: Linus Walleij , Arun Murthy , linux-next@vger.kernel.org, Stephen Rothwell , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: Make AB8500_PWM driver depend on U8500 due to PWM breakage Message-ID: <20101220130004.GG11095@sortiz-mobl> References: <20101220192121.47767525.sfr@canb.auug.org.au> <1292848091-29959-1-git-send-email-broonie@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1292848091-29959-1-git-send-email-broonie@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 29 Hi Mark, On Mon, Dec 20, 2010 at 12:28:11PM +0000, Mark Brown wrote: > Since we don't have a PWM API every PWM driver ends up exporting its > own version and we need to limit the platforms we try to build them on > in order to avoid multiple definitions. As the AB8500 is normally a > companion chip for the U8500 CPU depend on that architecture. > > Previously the driver was relying on the AB8500 core only being built > on U8500 but this did not give us build coverage of any of the other > functions for the device. > > Signed-off-by: Mark Brown > --- > > Here's a better way of solving the problem, Definitely nicer, yes. Patch applied, thanks a lot. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/