Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933133Ab0LTUAM (ORCPT ); Mon, 20 Dec 2010 15:00:12 -0500 Received: from cantor.suse.de ([195.135.220.2]:50682 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932744Ab0LTUAK (ORCPT ); Mon, 20 Dec 2010 15:00:10 -0500 Date: Mon, 20 Dec 2010 11:58:47 -0800 From: Greg KH To: merez@codeaurora.org Cc: Greg KH , linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, David Brownell , linux-kernel@vger.kernel.org Subject: Re: [RFC/PATCH v2] usb: Add streams support to epautoconf. Message-ID: <20101220195847.GA2479@suse.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 27 On Mon, Dec 20, 2010 at 11:33:44AM -0800, merez@codeaurora.org wrote: > > On Thu, Dec 16, 2010 at 10:15AM, Greg KH wrote: > > What do you exactly mean by "proprietary search algorithm"? > Our implementation for finding an EP with the required number of streams > may not fit the needs and platform definitions of all controllers. For > example, having the minimum number of streams as a parameter will allow > controllers to compromise on the number of required streams in case there > is no EP that answers their first request. > At the beginning of usb_ep_autoconfig we could see many if statements for > finding the fitting EP for several controllers (for example > gadget_is_net2280). The new gadget op will prevent having additional if > statements in the usb_ep_autoconfig in case a different search is needed. Ok, but please note the word of "proprietary" usually means something else when talking about kernel code (i.e. licensing issues.) I'll be glad to take this type of patch when you also provide a patch that uses the callback, but not before then. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/