Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933147Ab0LUAla (ORCPT ); Mon, 20 Dec 2010 19:41:30 -0500 Received: from sabe.cs.wisc.edu ([128.105.6.20]:43481 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933073Ab0LUAl3 (ORCPT ); Mon, 20 Dec 2010 19:41:29 -0500 Message-ID: <4D0FF6A5.9040209@cs.wisc.edu> Date: Mon, 20 Dec 2010 18:36:53 -0600 From: Mike Christie User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: "Nicholas A. Bellinger" CC: Matthew Wilcox , linux-scsi , linux-kernel , James Bottomley , Jeff Garzik , Christoph Hellwig , FUJITA Tomonori , Hannes Reinecke , Open iSCSI Subject: Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interrupts disabled internally References: <1292793727-31957-1-git-send-email-nab@linux-iscsi.org> <1292793727-31957-2-git-send-email-nab@linux-iscsi.org> <20101219233835.GJ1263@parisc-linux.org> <1292807703.20840.29.camel@haakon2.linux-iscsi.org> <1292808126.20840.33.camel@haakon2.linux-iscsi.org> <20101220020758.GK1263@parisc-linux.org> <1292837413.20840.47.camel@haakon2.linux-iscsi.org> In-Reply-To: <1292837413.20840.47.camel@haakon2.linux-iscsi.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 871 Lines: 19 On 12/20/2010 03:30 AM, Nicholas A. Bellinger wrote: > After a quick audit of iscsi_session->lock usage, and I see that > iscsi_complete_pdu(), iscsi_tmf_timedout(), iscsi_eh_cmd_timed_out(), > iscsi_check_transport_timeouts() are using spin_lock(), and > iscsi_session_failure() and iscsi_conn_failure() are using > spin_lock_irqsave(). > > Mike and Hannes, would you guys mind commenting on this..? From what I > can determine these should all be converted to use spin_lock_bh(), > yes..? > Yeah, they can use _bh locking. I was going to use them for qla4xxx eh, which does iscsi processing in its irq, but we never did. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/