Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933137Ab0LUImJ (ORCPT ); Tue, 21 Dec 2010 03:42:09 -0500 Received: from mail-ew0-f45.google.com ([209.85.215.45]:41369 "EHLO mail-ew0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754099Ab0LUImH (ORCPT ); Tue, 21 Dec 2010 03:42:07 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=bm+xxfNOorNgYMq9QXprA/Q38oHOB7WVT7dB59sA3GbyPKp6ps77o7tuJYtw3DkiFl ZMQhSpw/S6bl0uLHZJVKQbl0LBoyw7XAfgWYP7+3MJBzUh87OAOasluar2LW1Y82BDNc l2fD2duRPf7JAhMkMuvKOvhviAkBatvstiu+Y= Date: Tue, 21 Dec 2010 11:42:00 +0300 From: Kulikov Vasiliy To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Maciej Rutecki , Florian Mickler , Stephen Kitt , bugzilla-daemon@bugzilla.kernel.org Subject: Re: [Bug #24392] AGP aperture disabled, worked in 2.6.35 Message-ID: <20101221084200.GA2537@albatros> References: <201012201214.57068.bjorn.helgaas@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201012201214.57068.bjorn.helgaas@hp.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 23 Hi, On Mon, Dec 20, 2010 at 12:14 -0700, Bjorn Helgaas wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=24392 > > First-Bad-Commit: http://git.kernel.org/linus/96576a9e1a0cdb8a43d3af5846be0948f52b4460 ... > That's kind of ugly because it's an exception to the normal "call > pci_enable_device() first" rule, and it leads to bogus "conflicts" > like this: I don't understand rationale, but if standard enable-before-use breaks the boot then explicit comment _why_ do it is necessary here. Thanks, -- Vasiliy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/