Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978Ab0LUXpJ (ORCPT ); Tue, 21 Dec 2010 18:45:09 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:25849 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865Ab0LUXpH (ORCPT ); Tue, 21 Dec 2010 18:45:07 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6204"; a="67788401" Message-ID: In-Reply-To: <20101215134107.0354c0c3@nehalam> References: <1292437866-11652-1-git-send-email-nvishwan@codeaurora.org> <20101215134107.0354c0c3@nehalam> Date: Tue, 21 Dec 2010 15:44:52 -0800 (PST) Subject: Re: [PATCH] msm: rmnet: msm rmnet smd virtual ethernet driver From: nvishwan@codeaurora.org To: "Stephen Hemminger" Cc: "Niranjana Vishwanathapura" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Brian Swetland" User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 23 > On Wed, 15 Dec 2010 10:31:06 -0800 > Niranjana Vishwanathapura wrote: > >> +static struct net_device_stats *rmnet_get_stats(struct net_device *dev) >> +{ >> + struct rmnet_private *p = netdev_priv(dev); >> + return &p->stats; >> +} >> + > > Just use dev->stats and this function would no longer be needed. > > -- > This function will be a function pointer (ndo_get_stats) in net_device_ops structure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/