Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033Ab0LUXph (ORCPT ); Tue, 21 Dec 2010 18:45:37 -0500 Received: from sabe.cs.wisc.edu ([128.105.6.20]:46201 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846Ab0LUXpe (ORCPT ); Tue, 21 Dec 2010 18:45:34 -0500 Message-ID: <4D113BB5.2020802@cs.wisc.edu> Date: Tue, 21 Dec 2010 17:43:49 -0600 From: Mike Christie User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Boaz Harrosh CC: "Nicholas A. Bellinger" , linux-scsi , linux-kernel , James Bottomley , Jeff Garzik , Christoph Hellwig , FUJITA Tomonori , Hannes Reinecke , Mike Anderson , Tejun Heo , Vasu Dev , Tim Chen , Andi Kleen , Ravi Anand , Andrew Vasquez , Joe Eykholt , James Smart , Douglas Gilbert , adam radford , Kashyap Desai , MPTFusionLinux Subject: Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interrupts disabled internally References: <1292793727-31957-1-git-send-email-nab@linux-iscsi.org> <1292793727-31957-2-git-send-email-nab@linux-iscsi.org> <4D0FF7E6.2060104@cs.wisc.edu> <4D108726.2080003@panasas.com> In-Reply-To: <4D108726.2080003@panasas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 31 On 12/21/2010 04:53 AM, Boaz Harrosh wrote: > On 12/21/2010 02:42 AM, Mike Christie wrote: >> On 12/19/2010 03:21 PM, Nicholas A. Bellinger wrote: >>> prepd_fault: >>> @@ -1732,12 +1728,10 @@ fault: >>> scsi_out(sc)->resid = scsi_out(sc)->length; >>> scsi_in(sc)->resid = scsi_in(sc)->length; >>> } >>> - done(sc); >>> - spin_lock(host->host_lock); >>> + sc->scsi_done(sc); >>> return 0; >> >> >> Did you mean to send this patch or a different one? I think you sent a >> patch with this before and I said it was wrong. Did you disagree with >> that comment or did you change something else so it now works? > > Mike hi > > I think Nick is gone for the holidays. What I understood is that he's > waiting for you to fix it. Because he's not sure what the proper solution > is. Do you have time to look into it? (It will take you much faster then me) > I am still working on it for the 2.6.38 feature window. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/