Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613Ab0LVOG2 (ORCPT ); Wed, 22 Dec 2010 09:06:28 -0500 Received: from canuck.infradead.org ([134.117.69.58]:54747 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966Ab0LVOG1 convert rfc822-to-8bit (ORCPT ); Wed, 22 Dec 2010 09:06:27 -0500 Subject: Re: [PATCH 5/5] Account ksoftirqd time as cpustat softirq -v2 From: Peter Zijlstra To: Venkatesh Pallipadi Cc: Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Balbir Singh , Martin Schwidefsky , linux-kernel@vger.kernel.org, Paul Turner , Eric Dumazet , Shaun Ruffell In-Reply-To: References: <1292980144-28796-1-git-send-email-venki@google.com> <1292980144-28796-6-git-send-email-venki@google.com> <1293009621.2170.72.camel@laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 22 Dec 2010 15:05:24 +0100 Message-ID: <1293026724.2170.137.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1090 Lines: 24 On Wed, 2010-12-22 at 05:59 -0800, Venkatesh Pallipadi wrote: > > So you add the ksoftirqd runtime as softirq time in the /proc/stat > > output? > > > > That seems dubious... > > > > Yes. Thats similar to what we do today. As long as we are in softirq, > whether bottomhalf or ksoftirqd, we account the tick as softirq time > in /proc/stat. > I thought it also makes sense from user perspective. They want to know > how much time are we currently spending serving softirqs and hardirqs. > It is better to get that information at one place, instead of say look > at /proc/stat and add percpu ksoftirqd time to it. I mean, > user/administrator does not have to care whether ksoftirqd is involved > or not to know how much time was spend serving softirqs. > But ksoftirqd time is also counted as sys time, so somewhere this won't add up to 100%. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/