Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753687Ab0LVPZy (ORCPT ); Wed, 22 Dec 2010 10:25:54 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52901 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753598Ab0LVPZw (ORCPT ); Wed, 22 Dec 2010 10:25:52 -0500 Date: Wed, 22 Dec 2010 15:25:51 +0000 From: Mark Brown To: Rabin Vincent Cc: Ben Dooks , Jean Delvare , "Rafael J. Wysocki" , Alan Stern , linux-pm@lists.linux-foundation.org, patches@opensource.wolfsonmicro.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [linux-pm] [PATCH 2/2] i2c: Factor out runtime suspend checks from PM operations Message-ID: <20101222152550.GA16099@opensource.wolfsonmicro.com> References: <1292855593-30608-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1292855593-30608-2-git-send-email-broonie@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You look tired. User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 13 On Wed, Dec 22, 2010 at 08:40:23PM +0530, Rabin Vincent wrote: > Shouldn't you be deleting the pm_runtime_* stuff from here? There is > already done in pm_generic_restore() iff the callback exists and returns > zero. I guess; it's not clear why this is being done by the bus at all or how it interacts with the legacy stuff. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/