Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753739Ab0LVP0E (ORCPT ); Wed, 22 Dec 2010 10:26:04 -0500 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:53610 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605Ab0LVPZx convert rfc822-to-8bit (ORCPT ); Wed, 22 Dec 2010 10:25:53 -0500 Date: Wed, 22 Dec 2010 16:25:46 +0100 From: Martin Schwidefsky To: Venkatesh Pallipadi Cc: Peter Zijlstra , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Balbir Singh , linux-kernel@vger.kernel.org, Paul Turner , Eric Dumazet , Shaun Ruffell Subject: Re: [PATCH 2/5] Add nsecs_to_cputime64 interface for asm-generic -v2 Message-ID: <20101222162546.05d1c9cd@mschwide.boeblingen.de.ibm.com> In-Reply-To: References: <1292980144-28796-1-git-send-email-venki@google.com> <1292980144-28796-3-git-send-email-venki@google.com> <20101222093032.0320c9bf@mschwide.boeblingen.de.ibm.com> Organization: IBM Corporation X-Mailer: Claws Mail 3.7.8 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2573 Lines: 62 On Wed, 22 Dec 2010 06:23:55 -0800 Venkatesh Pallipadi wrote: > On Wed, Dec 22, 2010 at 12:30 AM, Martin Schwidefsky > wrote: > > On Tue, 21 Dec 2010 17:09:01 -0800 > > Venkatesh Pallipadi wrote: > > > >> Add nsecs_to_cputime64 interface. This is used in following patches that > >> updates cpu irq stat based on ns granularity info in IRQ_TIME_ACCOUNTING. > >> > >> Tested-by: Shaun Ruffell > >> Signed-off-by: Venkatesh Pallipadi > >> --- > >>  include/asm-generic/cputime.h |    3 +++ > >>  include/linux/jiffies.h       |    1 + > >>  kernel/time.c                 |   23 +++++++++++++++++++++-- > >>  3 files changed, 25 insertions(+), 2 deletions(-) > >> > >> diff --git a/include/asm-generic/cputime.h b/include/asm-generic/cputime.h > >> index 2bcc5c7..61e03dd 100644 > >> --- a/include/asm-generic/cputime.h > >> +++ b/include/asm-generic/cputime.h > >> @@ -30,6 +30,9 @@ typedef u64 cputime64_t; > >>  #define cputime64_to_jiffies64(__ct) (__ct) > >>  #define jiffies64_to_cputime64(__jif)        (__jif) > >>  #define cputime_to_cputime64(__ct)   ((u64) __ct) > >> +#define cputime64_gt(__a, __b)               ((__a) >  (__b)) > >> + > >> +#define nsecs_to_cputime64(__ct)     nsecs_to_jiffies64(__ct) > >> > >> > >>  /* > > > > If you define a new cputime primitive it is not enough to add it to the > > generic cputime header. You have to add it to the arch-specific cputime > > header for ia64, powerpc and s390 as well. Otherwise the build will > > break with CONFIG_VIRT_CPU_ACCOUNTING=y on these architectures once the > > new primitive is used. > > > > But, those archs have arch specific cputime as well and so need a > different macro for nsecs_to_cputime64, instead of nsec_to_jiffies64. > Right? As of now this new primitive should not be used in those archs. > I guess this is something needed when using the primitive in future? Yes on both parts of the question. You need an independent implementation of the nsecs_to_cputime64 primitive for the architectures that have their own definition of cputime and this definition will be needed when the primitive is used is the future. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/