Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392Ab0LWBiw (ORCPT ); Wed, 22 Dec 2010 20:38:52 -0500 Received: from smtp-out.google.com ([216.239.44.51]:7816 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877Ab0LWBiu (ORCPT ); Wed, 22 Dec 2010 20:38:50 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=EIFgeWgk5gurAMEYe2nnGBGYKa3BMxrtFLxvsb+NNTO4T4GvPfxT+qo676TNPqAzBx DJ+0IhUFpBdljq4flrTg== Date: Wed, 22 Dec 2010 17:38:44 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haicheng Li , lethal@linux-sh.org, Andi Kleen , Shaohui Zheng , dave@linux.vnet.ibm.com, Greg KH Subject: Re: [3/7, v9] NUMA Hotplug Emulator: Add node hotplug emulation In-Reply-To: <20101222162723.72075372.akpm@linux-foundation.org> Message-ID: References: <20101210073119.156388875@intel.com> <20101210073242.462037866@intel.com> <20101222162723.72075372.akpm@linux-foundation.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 37 On Wed, 22 Dec 2010, Andrew Morton wrote: > > Index: linux-hpe4/mm/memory_hotplug.c > > =================================================================== > > --- linux-hpe4.orig/mm/memory_hotplug.c 2010-11-30 12:40:43.757622001 +0800 > > +++ linux-hpe4/mm/memory_hotplug.c 2010-11-30 14:02:33.877622002 +0800 > > @@ -924,3 +924,63 @@ > > } > > #endif /* CONFIG_MEMORY_HOTREMOVE */ > > EXPORT_SYMBOL_GPL(remove_memory); > > + > > +#ifdef CONFIG_DEBUG_FS > > +#include > > + > > +static struct dentry *memhp_debug_root; > > + > > +static ssize_t add_node_store(struct file *file, const char __user *buf, > > + size_t count, loff_t *ppos) > > +{ > > + nodemask_t mask; > > NODEMASK_ALLOC()? > We traditionally haven't been using NODEMASK_ALLOC() in sysfs (or, in this case, debugfs) functions because they're never deep in a call chain. Even for 4K node support, which isn't a supported config on any arch that allows CONFIG_MEMORY_HOTPLUG, this would only be 512 bytes on the short stack. I agree with the remainder of the points in your review and will be sending fixes against -mm, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/