Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743Ab0LWGOY (ORCPT ); Thu, 23 Dec 2010 01:14:24 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:41196 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577Ab0LWGOV convert rfc822-to-8bit (ORCPT ); Thu, 23 Dec 2010 01:14:21 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ojV9ez1ZIgaf21r2T7QINTjxPVNVUJhPuG73BYmdq1U5WYeom2G8Lh1NYxlL96CAAT v0gKEoqbQ8HFYyjErH+ZIJR6lwqoOtVzjQiRJXJyK4guDl5R/jBckXBV9uGnfurPhKGM GpvDU8Io3GojU5+pYplcI2KgChJNIudF9c5/w= MIME-Version: 1.0 In-Reply-To: <4D127D72.8050303@suse.cz> References: <1293047849-26078-1-git-send-email-dirk.brandewie@gmail.com> <1293047849-26078-2-git-send-email-dirk.brandewie@gmail.com> <4D127D72.8050303@suse.cz> Date: Thu, 23 Dec 2010 07:14:20 +0100 X-Google-Sender-Auth: QA1BMunAs3pYvDv46H8fYTHOpXg Message-ID: Subject: Re: [PATCH 1/4] of: Add support for linking device tree blobs into vmlinux From: Geert Uytterhoeven To: Michal Marek Cc: dirk.brandewie@gmail.com, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, microblaze-uclinux@itee.uq.edu.au, linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2393 Lines: 62 2010/12/22 Michal Marek : > On 22.12.2010 20:57, dirk.brandewie@gmail.com wrote: >> >> From: Dirk Brandewie >> >> This patch adds support for linking device tree blob(s) into >> vmlinux. Modifies asm-generic/vmlinux.lds.h to add linking >> .dtb sections into vmlinux. To maintain compatiblity with the of/fdt >> driver code platforms MUST copy the blob to a non-init memory location >> before the kernel frees the .init.* sections in the image. >> >> Modifies scripts/Makefile.lib to add a kbuild command to >> compile DTS files to device tree blobs and a rule to create objects to >> wrap the blobs for linking. >> >> STRUCT_ALIGNMENT is defined in vmlinux.lds.h for use in the rule to >> create wrapper objects for the dtb in Makefile.lib.  The >> STRUCT_ALIGN() macro in vmlinux.lds.h is modified to use the >> STRUCT_ALIGNMENT definition. >> >> The DTB's are placed on 32 byte boundries to allow parsing the blob >> with driver/of/fdt.c during early boot without having to copy the blob >> to get the structure alignment GCC expects. >> >> A DTB is linked in by adding the DTB object to the list of objects to >> be linked into vmlinux in the archtecture specific Makefile using >>    obj-y += foo.dtb.o >> >> Signed-off-by: Dirk Brandewie > > Hi, > > you can add > Acked-by: Michal Marek > but I thing this series should go through the tip tree, as your primary > target seems to be x86 and patch 2/4 depends on the ce4100 code that is only > in tip. If the two lines +# device tree blob +obj-$(CONFIG_X86_INTEL_CE) += ce4100.dtb.o are removed, patch 2/4 no longer depends on the ce4100 code. The summary and description for that patch don't mention anything about ce4100 anyway. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/