Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147Ab0LWP1k (ORCPT ); Thu, 23 Dec 2010 10:27:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752990Ab0LWP1h (ORCPT ); Thu, 23 Dec 2010 10:27:37 -0500 From: Jeff Moyer To: Shaohua Li Cc: lkml , Jens Axboe , vgoyal@redhat.com Subject: Re: [PATCH 2/2]block cfq: don't use atomic_t for cfq_group References: <1293072335.10593.22.camel@sli10-conroe> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Thu, 23 Dec 2010 10:26:29 -0500 In-Reply-To: <1293072335.10593.22.camel@sli10-conroe> (Shaohua Li's message of "Thu, 23 Dec 2010 10:45:35 +0800") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 13 Shaohua Li writes: > cfq_group->ref is used with queue_lock hold, the only exception is > cfq_set_request, which looks like a bug to me, so ref doesn't need > to be an atomic and atomic operation is slower. > > Signed-off-by: Shaohua Li Reviewed-by: Jeff Moyer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/