Date: Thu, 23 Dec 2010 09:35:44 -0800 (PST)
Message-Id: <20101223.093544.71126698.davem@davemloft.net>
To: ying.huang@intel.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        andi@firstfloor.org, peterz@infradead.org,
        torvalds@linux-foundation.org, mingo@elte.hu, rth@twiddle.net,
        linux@arm.linux.org.uk, starvik@axis.com, dhowells@redhat.com,
        ysato@users.sourceforge.jp, tony.luck@intel.com, takata@linux-m32r.org,
        geert@linux-m68k.org, monstr@monstr.eu, ralf@linux-mips.org,
        kyle@mcmartin.ca, schwidefsky@de.ibm.com, liqin.chen@sunplusct.com,
        mingo@redhat.com, chris@zankel.net
Subject: Re: [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG
From: David Miller <davem@davemloft.net>
In-Reply-To: <1293083003-19577-2-git-send-email-ying.huang@intel.com>
References: <1293083003-19577-1-git-send-email-ying.huang@intel.com>
	<1293083003-19577-2-git-send-email-ying.huang@intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 726
Lines: 22

From: Huang Ying <ying.huang@intel.com>
Date: Thu, 23 Dec 2010 13:43:20 +0800

> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -22,6 +22,7 @@ config SPARC
>  	select RTC_CLASS
>  	select RTC_DRV_M48T59
>  	select HAVE_IRQ_WORK
> +	select ARCH_HAVE_NMI_SAFE_CMPXCHG
>  	select HAVE_DMA_ATTRS
>  	select HAVE_DMA_API_DEBUG
>  	select HAVE_ARCH_JUMP_LABEL

This should only be set for "SPARC64".  SPARC32's cmpxchg uses spinlocks and
IRQ disabling, which is not NMI safe.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/