Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038Ab0LWWgM (ORCPT ); Thu, 23 Dec 2010 17:36:12 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45568 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776Ab0LWWgL (ORCPT ); Thu, 23 Dec 2010 17:36:11 -0500 Date: Thu, 23 Dec 2010 14:35:21 -0800 From: Andrew Morton To: David Rientjes Cc: Mel Gorman , Greg Kroah-Hartman , Kyle McMartin , Shaohua Li , KOSAKI Motohiro , Christoph Lameter , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm: page allocator: Adjust the per-cpu counter threshold when memory is low Message-Id: <20101223143521.f94a5106.akpm@linux-foundation.org> In-Reply-To: References: <1288169256-7174-1-git-send-email-mel@csn.ul.ie> <1288169256-7174-2-git-send-email-mel@csn.ul.ie> <20101126160619.GP22651@bombadil.infradead.org> <20101129095618.GB13268@csn.ul.ie> <20101129131626.GF15818@bombadil.infradead.org> <20101129150824.GF13268@csn.ul.ie> <20101129152230.GH15818@bombadil.infradead.org> <20101129155801.GG13268@csn.ul.ie> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 28 On Thu, 23 Dec 2010 14:18:38 -0800 (PST) David Rientjes wrote: > On Mon, 29 Nov 2010, Mel Gorman wrote: > > > Andrew, this patch was a performance fix but is a report saying that it > > fixes a functional regression in Fedora enough to push a patch torwards > > stable even though an explanation as to *why* it fixes the problem is missing? > > > > We had to pull aa454840 "mm: page allocator: calculate a better estimate > of NR_FREE_PAGES when memory is low and kswapd is awake" from 2.6.36 > internally because tests showed that it would cause the machine to stall > as the result of heavy kswapd activity. I merged it back with this fix as > it is pending in the -mm tree and it solves the issue we were seeing, so I > definitely think this should be pushed to -stable (and I would seriously > consider it for 2.6.37 inclusion even at this late date). How's about I send mm-page-allocator-adjust-the-per-cpu-counter-threshold-when-memory-is-low.patch in for 2.6.38 and tag it for backporting into 2.6.37.1 and 2.6.36.x? That way it'll get a bit of 2.6.38-rc testing before being merged into 2.6.37.x. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/