Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143Ab0LYRwC (ORCPT ); Sat, 25 Dec 2010 12:52:02 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:13880 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521Ab0LYRwB (ORCPT ); Sat, 25 Dec 2010 12:52:01 -0500 Date: Sat, 25 Dec 2010 18:42:15 +0100 (CET) From: Jesper Juhl To: Mariusz Kozlowski cc: linux-btrfs@vger.kernel.org, Chris Mason , linux-kernel@vger.kernel.org Subject: Re: [PATCH] BTRFS: Don't leak memory in btrfs_get_acl() In-Reply-To: <20101225150240.GA7938@mako-laptop> Message-ID: References: <20101225150240.GA7938@mako-laptop> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 30 On Sat, 25 Dec 2010, Mariusz Kozlowski wrote: > On Fri, Dec 24, 2010 at 11:45:21PM +0100, Jesper Juhl wrote: > > Hi, > > > > Currrently we leak memory in btrfs_get_acl::btrfs_get_acl() if > > posix_acl_from_xattr() fails. With this patch we do not. > > I sent similar patch some time ago but no reply from Chris so far. > > http://marc.info/?l=linux-kernel&m=129247984126414 > I was not aware of that. The patch looks fine (identical to mine), so I think Chris should just merge yours. Feel free to add: Reviewed-by: Jesper Juhl -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/