Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325Ab0L0CGd (ORCPT ); Sun, 26 Dec 2010 21:06:33 -0500 Received: from mga09.intel.com ([134.134.136.24]:19118 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308Ab0L0CGc (ORCPT ); Sun, 26 Dec 2010 21:06:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.60,232,1291622400"; d="scan'208";a="690929436" Subject: Re: -tip tree resume fail, bisect to 5bd5a45(x86: Add NX protection for kernel data) From: Lin Ming To: matthieu castet Cc: Andi Kleen , Peter Zijlstra , Siarhei Liakh , Xuxian Jiang , Ingo Molnar , Arjan van de Ven , lkml , tglx In-Reply-To: <20101224182644.062bdb3f@mat-laptop> References: <1290410581.2405.24.camel@minggr.sh.intel.com> <1290431008.2072.119.camel@laptop> <1290443379.4cea9a73cd9ce@imp.free.fr> <1290443758.2072.318.camel@laptop> <20101122164247.GC21836@basil.fritz.box> <20101123235527.54293b59@mat-laptop> <20101126183144.300a71a4@mat-laptop> <1291093230.2405.191.camel@minggr.sh.intel.com> <20101224182644.062bdb3f@mat-laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 27 Dec 2010 10:10:50 +0800 Message-ID: <1293415850.2565.269.camel@minggr.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2105 Lines: 69 On Sat, 2010-12-25 at 01:26 +0800, matthieu castet wrote: > Hi, > > Le Tue, 30 Nov 2010 13:00:30 +0800, > Lin Ming a écrit : > > > On Sat, 2010-11-27 at 01:31 +0800, mat wrote: > > > Le Tue, 23 Nov 2010 23:55:27 +0100, > > > mat a écrit : > > > > > > > Le Mon, 22 Nov 2010 17:42:47 +0100, > > > > Andi Kleen a écrit : > > > > > > > > > > That seems to be a S3 specific code path, that won't fix > > > > > > anything. Simply do: > > > > > > > > > > > > echo 0 > /sys/devices/system/cpu/cpu1/online; > > > > > > echo 1 > /sys/devices/system/cpu/cpu1/online; > > > > > > > > > > > > and your machine will explode.. > > > > > > > > > > The SMP startup trampoline is copied I believe > > > > > and only executed in real mode without page tables. > > > > > > > > > > So it's perhaps not the trampoline, but the early startup > > > > > code that ends up being broken. > > > > yes : > > > > acpi wakeup code and smp trampoline are copied in low memory > > > > (first 1MB). > > > > > > > > So they can't end up int the kernel data mapping ? > > > > > > > > So it should something else. > > > > > > > > I will try to investigate on this. > > > > > > > Unfortunately on my laptop supporting NX, suspend to ram seems > > > broken (even without this patch) and I got only one core, so I am > > > unable to test it. > > > > > > Does cpu suspend/resume is broken ? Or it is only S3 ? > > > > > > If yes, are there any interesting trace if we suspend only one core > > > with sysfs. > > > > echo 0 > /sys/devices/system/cpu/cpu1/online; > > echo 1 > /sys/devices/system/cpu/cpu1/online; > > > > then machine just reboots... > > > Ok, > > could you try the attached patch ? Unfortunately, it does not work against current tip/master(1f7107c8). Lin Ming > > Thanks > > Matthieu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/