Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763Ab0L1A3f (ORCPT ); Mon, 27 Dec 2010 19:29:35 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:44835 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152Ab0L1A3e (ORCPT ); Mon, 27 Dec 2010 19:29:34 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=XaZPcOubwmKWrVwbxH1IHctTL/KB+ZrZVyZgQo+dgScYIU7xLRELu7Y4ZrNJaqIEjT YRjLAYPiNkpVq37B6cz86O70V7cxbSCuY6NUqjmDpXpqKWP+UaqH6pohyIDolUQSrJTP Cy+bEy+rFtjQZTveuC1Ry/vNUAG3Id/oSP+ZQ= MIME-Version: 1.0 In-Reply-To: <20101227162021.de3af7bc.sfr@canb.auug.org.au> References: <20101223223634.8c92ef31.sfr@canb.auug.org.au> <20101227162021.de3af7bc.sfr@canb.auug.org.au> Date: Tue, 28 Dec 2010 01:29:33 +0100 Message-ID: Subject: Re: linux-next: build failure after merge of the final tree (ux500-core tree related) From: Linus Walleij To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Sundar Iyer , Dmitry Torokhov Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1870 Lines: 35 2010/12/27 Stephen Rothwell : > Hi all, > > On Thu, 23 Dec 2010 22:36:34 +1100 Stephen Rothwell wrote: >> >> After merging the final tree, today's linux-next build (powerpc allyesconfig) >> failed like this: >> >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_enable': >> drivers/input/keyboard/tc3589x-keypad.c:239: error: 'keypad' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_disable': >> drivers/input/keyboard/tc3589x-keypad.c:268: error: 'keypad' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c: At top level: >> drivers/input/keyboard/tc3589x-keypad.c:448: error: expected ',' or ';' before 'static' >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_init': >> drivers/input/keyboard/tc3589x-keypad.c:460: error: 'tc3589x_keypad_driver' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c: In function 'tc3589x_keypad_exit': >> drivers/input/keyboard/tc3589x-keypad.c:466: error: 'tc3589x_keypad_driver' undeclared (first use in this function) >> drivers/input/keyboard/tc3589x-keypad.c:466: warning: 'return' with a value, in function returning void >> >> Caused by commit 1967733650dac41c93954a187246c91430c4a94f >> ("input/tc3589x: add tc3589x keypad support"). > > This error is still there, so I reverted the above commit for today. Ooopsie, thanks for noticing. I've reverted this driver and pushed now. This driver will likely have to wait for the next merge window. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/