DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :content-type:content-transfer-encoding;
        b=fPTesvJKK7CmOg8haDL3Dk+8+iy5BU3uQ02CyH+COs7ymqTRTUIv7PRuPozO/uC/CW
         DdwqY6nT5dMg60pDk5cl94hNfoSDAmZJKpB9Gjs/gIzjjH+rWIq3VmoyCSiYbdnC0/uv
         d4IR+SmfOzmt39aBCiuIxkrlB8RAmTOdWvN8w=
Message-ID: <4D1A0B1C.70406@gmail.com>
Date: Tue, 28 Dec 2010 17:06:52 +0100
From: Marco Stornelli <marco.stornelli@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11
MIME-Version: 1.0
To: linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org
CC: Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>, tytso@mit.edu,
        chris.mason@oracle.com
Subject: Bug in ext4/btrfs fallocate?
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 922
Lines: 21

Hi,

it seems that ext4/btrfs code for fallocate doesn't check for
immutable/append inode flag. I think it's possible to do an fallocate
operation even if the immutable flag is turned on. You can think about
this case: an application opens a file for read/write, meanwhile a user
set the immutable flag and then the application calls fallocate. Other
cases shouldn't happen because if the immutable flag is turned on before
the application opens the file, then the application can't open the file
in read/write mode and therefore it can't do an fallocate operation.
Sincerely I haven't tried but I saw this kind of error in my own fs that
have a similar code.

Regards,

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/