Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141Ab0L1UTz (ORCPT ); Tue, 28 Dec 2010 15:19:55 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:52821 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900Ab0L1UTx (ORCPT ); Tue, 28 Dec 2010 15:19:53 -0500 Subject: Re: linux-next: Tree for December 28 (drivers/target/) From: "Nicholas A. Bellinger" To: Randy Dunlap Cc: James Bottomley , Stephen Rothwell , scsi , linux-next@vger.kernel.org, LKML , Joel Becker In-Reply-To: <4D1A42BF.4070401@oracle.com> References: <20101228173049.217c192d.sfr@canb.auug.org.au> <20101228082947.70b09534.randy.dunlap@oracle.com> <1293554355.2371.1.camel@fuzzy> <20101228085016.dedc8b18.randy.dunlap@oracle.com> <1293565125.4649.217.camel@haakon2.linux-iscsi.org> <4D1A42BF.4070401@oracle.com> Content-Type: text/plain Date: Tue, 28 Dec 2010 12:13:56 -0800 Message-Id: <1293567236.4649.221.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2541 Lines: 77 On Tue, 2010-12-28 at 12:04 -0800, Randy Dunlap wrote: > On 12/28/10 11:38, Nicholas A. Bellinger wrote: > > On Tue, 2010-12-28 at 08:50 -0800, Randy Dunlap wrote: > >> On Tue, 28 Dec 2010 10:39:14 -0600 James Bottomley wrote: > >> > >>> On Tue, 2010-12-28 at 08:29 -0800, Randy Dunlap wrote: > >>>> On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote: > >>>> > >>>>> Hi all, > >>>>> > >>>>> [The mirroring on kernel.org is running slowly] > >>>>> > >>>>> Changes since 20101227: > >>>> > >>>> > >>>> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS) > >>>> > >>>> from: > >>>> > >>>> menuconfig TARGET_CORE > >>>> tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure" > >>>> select CONFIGFS_FS > >>>> > >>>> but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS > >>>> or (eek) it should select SYSFS. > >>> > >>> The latter, I think (and actually, configfs should select sysfs). All > >>> these unmet dependencies are a minefield. > >> > >> It's just another language to deal with. Not a big deal, except for the > >> twists that EXPERIMENTAL injects into it. > > > > I agree with James on this one.. Attached is a patch to select SYSFS > > and fix up some extra whitespace breakage. (jlbec CC'ed) > > and I am not surprised. James is a more liberal 'select'or than I am. ;) > > > Thanks, > > > > --nab > > > > diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig > > index 13587cc..6874d75 100644 > > --- a/fs/configfs/Kconfig > > +++ b/fs/configfs/Kconfig > > @@ -1,11 +1,11 @@ > > config CONFIGFS_FS > > tristate "Userspace-driven configuration filesystem" > > - depends on SYSFS > > + select SYSFS > > help > > - configfs is a ram-based filesystem that provides the converse > > - of sysfs's functionality. Where sysfs is a filesystem-based > > - view of kernel objects, configfs is a filesystem-based manager > > - of kernel objects, or config_items. > > + configfs is a ram-based filesystem that provides the converse > > RAM-based > Fixed, and added as a single patch into the LIO tree tracking linux-next here: http://git.kernel.org/?p=linux/kernel/git/nab/linux-next.git;a=commitdiff;h=87b548329a29fbe54453f9ef47819ee39a32716d Thanks! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/