Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753668Ab0L2VLN (ORCPT ); Wed, 29 Dec 2010 16:11:13 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:50026 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335Ab0L2VLL convert rfc822-to-8bit (ORCPT ); Wed, 29 Dec 2010 16:11:11 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=fQ0kNNJLikiq6KqawH46jmz/Aoy6zXVyXA/LYxAR4cghJi8T0JLvSM8ur/R975GfWE jO3kRTr4PpH7pHbWThS8MzKKVFfeJQHCy0ISNeNqISzSHDsalCDmLVAdzS4YYZ2IzVbD GJfnDNfWmUeKThrV33h2bkBIRemOcg4L3c68k= MIME-Version: 1.0 In-Reply-To: <20101229121601.179983b7@jbarnes-desktop> References: <20101229102127.06c0e505.randy.dunlap@oracle.com> <20101229121601.179983b7@jbarnes-desktop> Date: Wed, 29 Dec 2010 22:11:09 +0100 Message-ID: Subject: Re: Linux 2.6.37-rc8 (no fb) From: Alex Riesen To: Jesse Barnes Cc: Linus Torvalds , Randy Dunlap , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, Jeff Chua Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1628 Lines: 33 On Wed, Dec 29, 2010 at 21:16, Jesse Barnes wrote: > On Wed, 29 Dec 2010 11:40:04 -0800 > Linus Torvalds wrote: >> Chris - why did that lvds_ssc_freq thing suddenly start mattering? Can >> we please just disable spread-spectrum entirely? Or perhaps only if we >> notice that it was enabled already? Or something? > > Randy, Jeff and Alex, does the below help at all?  If so, it may be the > minimal fix we want for 2.6.37. Something broke your patch: whitespace instead of tabs. > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios > index 2b20786..d27d016 100644 > --- a/drivers/gpu/drm/i915/intel_bios.c > +++ b/drivers/gpu/drm/i915/intel_bios.c > @@ -263,6 +263,9 @@ parse_general_features(struct drm_i915_private *dev_priv, >                dev_priv->int_tv_support = general->int_tv_support; >                dev_priv->int_crt_support = general->int_crt_support; >                dev_priv->lvds_use_ssc = general->enable_ssc; > +               /* force disable until we can parse this correctly */ This comment seems to imply that SSC wasn't used at all until recently, right? > +               if (IS_GEN5(dev) || IS_GEN6(dev)) > +                       dev_priv->lvds_use_ssc = 0; Doesn't change anything here. Display stays blank. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/