DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=BWVB7o/XUZOhCm+DXm/s6XLLaSJqN+LaTHG6fUduTtwDvj42Yju+K4960didwfp6+B
         Scxz7Cotlj9Di5RJWxy5WJagFJct/DuNtF8hrsFSDb72dqdh+GX8InIWTM9HynXci1wo
         1Lq3ZDlywzvfv784bxp2iAvz0tIc1fiudPe9U=
MIME-Version: 1.0
In-Reply-To: <AANLkTik38TzE_L_m8KpG-PmWGPeHjC8FYU=reRN8L7E5@mail.gmail.com>
References: <20101229125129.d48fb6fc.sfr@canb.auug.org.au>
	<20101229023457.GA4206@core.coreip.homeip.net>
	<20101230105130.5d27a82b.sfr@canb.auug.org.au>
	<AANLkTik38TzE_L_m8KpG-PmWGPeHjC8FYU=reRN8L7E5@mail.gmail.com>
Date: Thu, 30 Dec 2010 20:58:17 +0100
Message-ID: <AANLkTik3M2msXQA2Q--r492Oohph9cD7=JYBWx=vNzg-@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the final tree (input
 tree related)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1942
Lines: 46

On Thu, Dec 30, 2010 at 19:06, Ping Cheng <pinglinux@gmail.com> wrote:
> On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>>> > After merging the final tree, today's linux-next build (powerpc
>>> > allyesconfig) failed like this:
>>> >
>>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>>> >
>>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>>> > wacom_w8001 - support pen or touch only devices").  See Rule 1 in
>>> > Documentation/SubmitChecklist.
>
> I do not see the error on my testing systems somehow. Does adding the
> following line resolve the issue?
>
> #include < include/linux/delay.h>

"#include <linux/delay.h>", I assume?

>>> > I have reverted that commit for today.
>>>
>>> Thank you Stephen, I'll fix this up in my tree.
>>
>> I note that this commit has been redone in your tree (as commit
>> 11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
>> to it at all (except the commit date).
>>
>> I have reverted that commit from today's linux-next.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/