Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481Ab1BAKE1 (ORCPT ); Tue, 1 Feb 2011 05:04:27 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:56777 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916Ab1BAKEZ (ORCPT ); Tue, 1 Feb 2011 05:04:25 -0500 Date: Tue, 1 Feb 2011 21:04:21 +1100 From: Simon Horman To: Randy Dunlap Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org, Stephen Rothwell , Hans Schillstrom , Patrick McHardy Subject: Re: [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups Message-ID: <20110201100421.GA13325@verge.net.au> References: <1296519255-10602-1-git-send-email-horms@verge.net.au> <20110131165009.66999952.randy.dunlap@oracle.com> <20110201040634.GA2351@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110201040634.GA2351@verge.net.au> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2465 Lines: 62 On Tue, Feb 01, 2011 at 03:06:37PM +1100, Simon Horman wrote: > On Mon, Jan 31, 2011 at 04:50:09PM -0800, Randy Dunlap wrote: > > On Tue, 1 Feb 2011 11:14:11 +1100 Simon Horman wrote: > > > > > Hi, > > > > > > This short patch series addresses two linux-next build problems > > > raised by Randy Dunlap: > > > > > > * net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int' > > > * ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] > > > ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined! > > > > > > The remainder of the changset is cleanups that I noticed along the way. > > > > These 4 patches build successfully for me. > > However, I do see these warnings (sorry I missed them earlier): > > > > WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup() > > WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup() > > Thanks, I'll look into that. I will be travelling for a good portion of the > next day and a bit so I apologise in advance if that delays my next patch. Hi, I the following patch seems to be the right fix for this to me. I will send an amended pull request. IPVS: Remove ip_vs_sync_cleanup from section __exit ip_vs_sync_cleanup() may be called from ip_vs_init() on error and thus needs to be accesible from section __init Reporte-by: Randy Dunlap Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_sync.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c index d5a6e64..2a2a836 100644 --- a/net/netfilter/ipvs/ip_vs_sync.c +++ b/net/netfilter/ipvs/ip_vs_sync.c @@ -1686,7 +1686,7 @@ int __init ip_vs_sync_init(void) return register_pernet_subsys(&ipvs_sync_ops); } -void __exit ip_vs_sync_cleanup(void) +void ip_vs_sync_cleanup(void) { unregister_pernet_subsys(&ipvs_sync_ops); } -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/