Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755580Ab1BART7 (ORCPT ); Tue, 1 Feb 2011 12:19:59 -0500 Received: from stinky.trash.net ([213.144.137.162]:46136 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949Ab1BART6 (ORCPT ); Tue, 1 Feb 2011 12:19:58 -0500 Message-ID: <4D4840BC.4050303@trash.net> Date: Tue, 01 Feb 2011 18:19:56 +0100 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Randy Dunlap CC: Simon Horman , netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org, Stephen Rothwell , Hans Schillstrom Subject: Re: [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups References: <1296519255-10602-1-git-send-email-horms@verge.net.au> <20110131165009.66999952.randy.dunlap@oracle.com> <20110201040634.GA2351@verge.net.au> <20110201100421.GA13325@verge.net.au> <4D483D6E.5070007@oracle.com> In-Reply-To: <4D483D6E.5070007@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2267 Lines: 50 Am 01.02.2011 18:05, schrieb Randy Dunlap: > On 02/01/11 02:04, Simon Horman wrote: >> On Tue, Feb 01, 2011 at 03:06:37PM +1100, Simon Horman wrote: >>> On Mon, Jan 31, 2011 at 04:50:09PM -0800, Randy Dunlap wrote: >>>> On Tue, 1 Feb 2011 11:14:11 +1100 Simon Horman wrote: >>>> >>>>> Hi, >>>>> >>>>> This short patch series addresses two linux-next build problems >>>>> raised by Randy Dunlap: >>>>> >>>>> * net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int' >>>>> * ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] >>>>> ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined! >>>>> >>>>> The remainder of the changset is cleanups that I noticed along the way. >>>> >>>> These 4 patches build successfully for me. >>>> However, I do see these warnings (sorry I missed them earlier): >>>> >>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup() >>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup() >>> >>> Thanks, I'll look into that. I will be travelling for a good portion of the >>> next day and a bit so I apologise in advance if that delays my next patch. >> >> Hi, >> >> I the following patch seems to be the right fix for this to me. >> I will send an amended pull request. >> >> IPVS: Remove ip_vs_sync_cleanup from section __exit >> >> ip_vs_sync_cleanup() may be called from ip_vs_init() on error >> and thus needs to be accesible from section __init >> >> Reporte-by: Randy Dunlap > Reported-by: > >> Signed-off-by: Simon Horman > > Acked-by: Randy Dunlap Thanks, since Simon is travelling, I'll apply the patches now with your and Hans's Acks and will push them to Dave later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/