Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905Ab1BAVJq (ORCPT ); Tue, 1 Feb 2011 16:09:46 -0500 Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:16483 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633Ab1BAVJp (ORCPT ); Tue, 1 Feb 2011 16:09:45 -0500 Date: Tue, 1 Feb 2011 13:09:44 -0800 From: Dmitry Torokhov To: Geert Uytterhoeven Cc: Rusty Russell , "linux-kernel@vger.kernel.org" , Linux/m68k Subject: Re: Early crash (was: Re: module: show version information for built-in modules in sysfs) Message-ID: <20110201210944.GA12348@dtor-ws.eng.vmware.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2074 Lines: 57 On Tue, Feb 01, 2011 at 12:33:29PM -0800, Geert Uytterhoeven wrote: > On Mon, Jan 24, 2011 at 11:59, Linux Kernel Mailing List > wrote: > > Gitweb: ? ? http://git.kernel.org/linus/e94965ed5beb23c6fabf7ed31f625e66d7ff28de > > > ? ?module: show version information for built-in modules in sysfs > > > > ? ?Currently only drivers that are built as modules have their versions > > ? ?shown in /sys/module//version, but this information might > > ? ?also be useful for built-in drivers as well. This especially important > > ? ?for drivers that do not define any parameters - such drivers, if > > ? ?built-in, are completely invisible from userspace. > > > > ? ?This patch changes MODULE_VERSION() macro so that in case when we are > > ? ?compiling built-in module, version information is stored in a separate > > ? ?section. Kernel then uses this data to create 'version' sysfs attribute > > ? ?in the same fashion it creates attributes for module parameters. > > This commit causes the crash below on m68k (ARAnyM). > Reverting this commit and its dependency > 3b90a5b292321b2acac3921f77046ae195aef53f > ("module: fix linker error for MODULE_VERSION when !MODULE and CONFIG_SYSFS=n") > makes it boot again. > Hi Geert, Does the follwing help by any chance? >From d6fd4a6e0fc2d3f0a74962d4a6f663a46d230ecd Mon Sep 17 00:00:00 2001 diff --git a/arch/m68knommu/kernel/vmlinux.lds.S b/arch/m68knommu/kernel/vmlinux.lds.S index ef33213..47e15eb 100644 --- a/arch/m68knommu/kernel/vmlinux.lds.S +++ b/arch/m68knommu/kernel/vmlinux.lds.S @@ -141,6 +141,12 @@ SECTIONS { *(__param) __stop___param = .; + /* Built-in module versions */ + . = ALIGN(4) ; + __start___modver = .; + *(__modver) + __stop___modver = .; + . = ALIGN(4) ; _etext = . ; } > TEXT Thanks, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/