Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787Ab1BAVXX (ORCPT ); Tue, 1 Feb 2011 16:23:23 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:44306 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247Ab1BAVXW (ORCPT ); Tue, 1 Feb 2011 16:23:22 -0500 Subject: Re: [patch 17/28] posix-timers: Convert timer_gettime() to clockid_to_kclock() From: john stultz To: Thomas Gleixner Cc: LKML , Richard Cochran , Ingo Molnar , Peter Zijlstra In-Reply-To: <20110201134419.101243181@linutronix.de> References: <20110201134320.688829863@linutronix.de> <20110201134419.101243181@linutronix.de> Content-Type: text/plain; charset="UTF-8" Date: Tue, 01 Feb 2011 13:23:16 -0800 Message-ID: <1296595396.3336.61.camel@work-vm> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 26 On Tue, 2011-02-01 at 13:52 +0000, Thomas Gleixner wrote: > plain text document attachment (posix-timers-convert-timer-get.patch) > Set the common function for CLOCK_MONOTONIC and CLOCK_REALTIME kclocks > and use the new decoding function. No need to check for the return > value of it. If we have data corruption in the timer, we explode > somewhere else anyway. Also all kclocks which implement timer_create() > need to provide timer_gettime() as well. > > Signed-off-by: Thomas Gleixner > Cc: John Stultz > Cc: Richard Cochran [snip] > - CLOCK_DISPATCH(timr->it_clock, timer_get, (timr, &cur_setting)); > + kc = clockid_to_kclock(timr->it_clock); > + kc->timer_get(timr, &cur_setting); Null check again. thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/