Date: Tue, 1 Feb 2011 23:07:45 +0100
From: Christoph Hellwig <hch@lst.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Christoph Hellwig <hch@tuxera.com>, linux-kernel@vger.kernel.org
Subject: Re: [Patch 0/4] Fix error handling in hfsplus mount failure paths
Message-ID: <20110201220745.GA23889@lst.de>
References: <20110201162802.2dd07201@katamari>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110201162802.2dd07201@katamari>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 814
Lines: 19

On Tue, Feb 01, 2011 at 04:28:02PM -0500, Chuck Ebbert wrote:
> hfsplus can generate NULL pointer exceptions when a user attempts
> to mount an invalid filesystem. In some paths it also leaks memory.
> 
> This series attempts to fix some of the most obvious problems.

Not in a very nice way, though.  The real problem here is that we

 a) can still return a failure after sb->s_root is set
 b) abuse hfsplus_put_super for error handling, which is totally
    ill-suited.

Take a look at the patch in
https://bugzilla.kernel.org/show_bug.cgi?id=27932 for a proper fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/