Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898Ab1BBLPg (ORCPT ); Wed, 2 Feb 2011 06:15:36 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:56404 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753521Ab1BBLPe (ORCPT ); Wed, 2 Feb 2011 06:15:34 -0500 From: Arnd Bergmann To: Bernhard Walle Subject: Re: [PATCH] spi: spidev: Add 32 bit compat ioctl() Date: Wed, 2 Feb 2011 12:15:28 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; ) Cc: dbrownell@users.sourceforge.net, grant.likely@secretlab.ca, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, akpm@linux-foundation.org References: <1296644235-23933-1-git-send-email-walle@corscience.de> In-Reply-To: <1296644235-23933-1-git-send-email-walle@corscience.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102021215.29002.arnd@arndb.de> X-Provags-ID: V02:K0:F9tW24i1i/btCbvs8FoeGM96kGZsxVx+FHWFBRZ7Hms ROBAm0kXaoVLwshBOdtJmGaugvHwtKxlcVHgrh5DtXg9ke2tem eaN+sZZ6RnggkyERKmlh5Jzk0aB+urlZbvgH/LAt0BqOxWpdoW Yj6k9eTy06r7vYds2hAKY5jheA4Sa7X73GVgF0dJ4Kk44LLoQu EFQWfaWYx73FYU6ZHC9jA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 852 Lines: 20 On Wednesday 02 February 2011, Bernhard Walle wrote: > Add the compat_ioctl for operations on /dev/spi* so that 32 bit > userspace applications can access SPI. As far as I can see all data > structure are already prepared for that, so no additional conversion has > to be done. > > My use case is MIPS with N32 userspace ABI and toolchain, and that was > also the platform where I tested it successfully (Cavium Octeon). > > Signed-off-by: Bernhard Walle I think you now need to #include as well, to get the definition of compat_ptr(). Otherwise looks good. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/