Subject: Re: [PATCH] RTC: Fix for issues in the kernel RTC API.
From: john stultz <johnstul@us.ibm.com>
To: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
        linux-kernel@vger.kernel.org
In-Reply-To: <1296685479.3336.298.camel@work-vm>
References: <1296577820-27456-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>
	 <1296615605.3336.239.camel@work-vm>
	 <AANLkTincYETuV-P5DG9cpgUL-hSoqAG=oQvS2kRUmAkb@mail.gmail.com>
	 <1296685479.3336.298.camel@work-vm>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 02 Feb 2011 14:28:02 -0800
Message-ID: <1296685682.3336.302.camel@work-vm>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1327
Lines: 33

On Wed, 2011-02-02 at 14:24 -0800, John Stultz wrote:
> On Wed, 2011-02-02 at 15:58 -0200, Marcelo Roberto Jimenez wrote: 
> > Again, what the rtc-test kernel RTC and the strongarm RTC user space
> > behavior have changed. Alarm interrupts and update interrupts were
> > generated by a different interrupts in the strongarm driver, and the
> > rtc-test driver also behaved similarly, i.e., an update interrupt did
> > not trigger an alarm interrupt. Currently, rtc_handle_legacy_irq()
> > centralizes the irq processing, and by not checking the generated
> > interrupt, it allows the new behavior, which seemed broken to me.
> 
> So 

Sorry. I didn't finish my thought here. (I *did not* mean "So?" :)

So... yes, we should make sure its not broken. Could you explain some
more details about the different interrupts fro the driver?  If the two
interrupt types come from different sources, is there a problem actually
using the alarm irq to emulate the update irq? In other words, can we
just skip the update irq management code? Or is there a draw back to
that?

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/