Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755998Ab1BCJ3o (ORCPT ); Thu, 3 Feb 2011 04:29:44 -0500 Received: from casper.infradead.org ([85.118.1.10]:32827 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479Ab1BCJ3m (ORCPT ); Thu, 3 Feb 2011 04:29:42 -0500 Subject: Re: Regression: WARNINGS and lockdep spews in 2.6.38-rc3+ (bisected). From: Peter Zijlstra To: Yong Zhang Cc: Nick Bowler , linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner In-Reply-To: <20110203091227.GA1603@zhy> References: <20110203031943.GA8910@elliptictech.com> <20110203091227.GA1603@zhy> Content-Type: text/plain; charset="UTF-8" Date: Thu, 03 Feb 2011 10:30:40 +0100 Message-ID: <1296725440.26581.354.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 25 On Thu, 2011-02-03 at 17:12 +0800, Yong Zhang wrote: > #ifdef CONFIG_LOCKDEP > + unsigned long flags; > + > local_bh_disable(); > lock_map_acquire(&timer->lockdep_map); > lock_map_release(&timer->lockdep_map); > - local_bh_enable(); > + /* raw_local_irq_[save|restore] is to protect _local_bh_enable() */ > + raw_local_irq_save(flags); > + _local_bh_enable(); > + raw_local_irq_restore(flags); > #endif _why_ are you doing the raw_local_irq stuff? That's just weird, and that comment isn't helping. Also, calling _local_bh_enable() will leave pending softirqs, not particularly nice -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/