Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756493Ab1BCQL3 (ORCPT ); Thu, 3 Feb 2011 11:11:29 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:1665 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755559Ab1BCQL1 (ORCPT ); Thu, 3 Feb 2011 11:11:27 -0500 From: Andrey Vagin To: Al Viro Cc: Tejun Heo , Andrew Morton , linux-kernel@vger.kernel.org, Andrey Vagin Subject: [PATCH] fs: Correctly check d_alloc_name() return code in devpts_pty_new Date: Thu, 3 Feb 2011 19:07:37 +0300 Message-Id: <1296749257-12993-1-git-send-email-avagin@openvz.org> X-Mailer: git-send-email 1.7.2.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 31 d_alloc_name return NULL in case error, but we expect errno in devpts_pty_new. http://bugzilla.openvz.org/show_bug.cgi?id=1758 Signed-off-by: Andrey Vagin --- fs/devpts/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index 1bb547c..8392c8c 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c @@ -501,7 +501,7 @@ int devpts_pty_new(struct inode *ptmx_inode, struct tty_struct *tty) mutex_lock(&root->d_inode->i_mutex); dentry = d_alloc_name(root, s); - if (!IS_ERR(dentry)) { + if (dentry) { d_add(dentry, inode); fsnotify_create(root->d_inode, dentry); } -- 1.7.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/