Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932527Ab1BCTQ1 (ORCPT ); Thu, 3 Feb 2011 14:16:27 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:10144 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932221Ab1BCTQ0 (ORCPT ); Thu, 3 Feb 2011 14:16:26 -0500 Date: Thu, 3 Feb 2011 20:15:28 +0100 (CET) From: Jesper Juhl To: linux-nfs@vger.kernel.org cc: linux-kernel@vger.kernel.org, Trond Myklebust , Neil Brown , bfields@fieldses.org Subject: [PATCH] Fix size argument to memset call in nfsacl_encode Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 31 We want to give memset() the sizeof(struct posix_acl), not sizeof(struct posix_acl *). Signed-off-by: Jesper Juhl --- nfsacl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c index 84c27d6..bc6d81b 100644 --- a/fs/nfs_common/nfsacl.c +++ b/fs/nfs_common/nfsacl.c @@ -117,7 +117,7 @@ int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode, * invoked in contexts where a memory allocation failure is * fatal. Fortunately this fake ACL is small enough to * construct on the stack. */ - memset(acl2, 0, sizeof(acl2)); + memset(acl2, 0, sizeof(*acl2)); posix_acl_init(acl2, 4); /* Insert entries in canonical order: other orders seem -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/