Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754897Ab1BDAHw (ORCPT ); Thu, 3 Feb 2011 19:07:52 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:37287 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754693Ab1BDAHv (ORCPT ); Thu, 3 Feb 2011 19:07:51 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 4 Feb 2011 09:01:45 +0900 From: KAMEZAWA Hiroyuki To: Johannes Weiner Cc: Andrew Morton , Daisuke Nishimura , Balbir Singh , , Subject: Re: [patch 1/5] memcg: no uncharged pages reach page_cgroup_zoneinfo Message-Id: <20110204090145.7f1918fc.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1296743166-9412-2-git-send-email-hannes@cmpxchg.org> References: <1296743166-9412-1-git-send-email-hannes@cmpxchg.org> <1296743166-9412-2-git-send-email-hannes@cmpxchg.org> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 41 On Thu, 3 Feb 2011 15:26:02 +0100 Johannes Weiner wrote: > All callsites check PCG_USED before passing pc->mem_cgroup, so the > latter is never NULL. > > Signed-off-by: Johannes Weiner Acked-by: KAMEZAWA Hiroyuki I want BUG_ON() here. > --- > mm/memcontrol.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e071d7e..85b4b5a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -370,9 +370,6 @@ page_cgroup_zoneinfo(struct page_cgroup *pc) > int nid = page_cgroup_nid(pc); > int zid = page_cgroup_zid(pc); > > - if (!mem) > - return NULL; > - > return mem_cgroup_zoneinfo(mem, nid, zid); > } > > -- > 1.7.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/