Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755014Ab1BDANr (ORCPT ); Thu, 3 Feb 2011 19:13:47 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:36590 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183Ab1BDANq (ORCPT ); Thu, 3 Feb 2011 19:13:46 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 4 Feb 2011 09:07:38 +0900 From: KAMEZAWA Hiroyuki To: Johannes Weiner Cc: Andrew Morton , Daisuke Nishimura , Balbir Singh , , Subject: Re: [patch 3/5] memcg: fold __mem_cgroup_move_account into caller Message-Id: <20110204090738.4eb6d766.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1296743166-9412-4-git-send-email-hannes@cmpxchg.org> References: <1296743166-9412-1-git-send-email-hannes@cmpxchg.org> <1296743166-9412-4-git-send-email-hannes@cmpxchg.org> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 20 On Thu, 3 Feb 2011 15:26:04 +0100 Johannes Weiner wrote: > It is one logical function, no need to have it split up. > > Also, get rid of some checks from the inner function that ensured the > sanity of the outer function. > > Signed-off-by: Johannes Weiner I think there was a reason to split them...but it seems I forget it.. The patch seems good. Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/