Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755244Ab1BDBCd (ORCPT ); Thu, 3 Feb 2011 20:02:33 -0500 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:50060 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852Ab1BDBCc (ORCPT ); Thu, 3 Feb 2011 20:02:32 -0500 Date: Fri, 4 Feb 2011 09:53:54 +0900 From: Daisuke Nishimura To: KAMEZAWA Hiroyuki Cc: Johannes Weiner , Andrew Morton , Balbir Singh , , , Daisuke Nishimura Subject: Re: [patch 3/5] memcg: fold __mem_cgroup_move_account into caller Message-Id: <20110204095354.7332d8d4.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20110204090738.4eb6d766.kamezawa.hiroyu@jp.fujitsu.com> References: <1296743166-9412-1-git-send-email-hannes@cmpxchg.org> <1296743166-9412-4-git-send-email-hannes@cmpxchg.org> <20110204090738.4eb6d766.kamezawa.hiroyu@jp.fujitsu.com> Organization: NEC Soft, Ltd. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 35 On Fri, 4 Feb 2011 09:07:38 +0900 KAMEZAWA Hiroyuki wrote: > On Thu, 3 Feb 2011 15:26:04 +0100 > Johannes Weiner wrote: > > > It is one logical function, no need to have it split up. > > > > Also, get rid of some checks from the inner function that ensured the > > sanity of the outer function. > > > > Signed-off-by: Johannes Weiner > > I think there was a reason to split them...but it seems I forget it.. > IIRC, it's me who split them up in commit 57f9fd7d. But the purpose of the commit was cleanup move_parent() and move_account() to use move_accout() in move_charge() later. So, there was no technical reason why I split move_account() and __move_account(). It was just because I liked to make each functions do one thing: check validness and actually move account. Anyway, I don't have any objection to folding them. page_is_cgroup_locked() can be removed by this change. Acked-by: Daisuke Nishimura Thanks, Daisuke Nishimura. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/