Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755499Ab1BDBmh (ORCPT ); Thu, 3 Feb 2011 20:42:37 -0500 Received: from mail-vw0-f46.google.com ([209.85.212.46]:47680 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877Ab1BDBme (ORCPT ); Thu, 3 Feb 2011 20:42:34 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=J+DLK1mVFzQoRmfZmTfJkBXBIQDm+4TYLxqkGzLIQIEqeaIDLwU1sDeIunZLMpeRRU AvVfvCqJW7N4kW3GCXHLNehFDPZCml3aD3N/hXnmrAh9AQ2q+YaBlrUQZwdrHM3MTlF8 au60JKzGD/WRe9N28VEfIQfIHcXGcudvcfVCk= MIME-Version: 1.0 In-Reply-To: References: <201102032009.17100.rjw@sisk.pl> Date: Fri, 4 Feb 2011 11:42:33 +1000 Message-ID: Subject: Re: 2.6.38-rc3-git1: Reported regressions 2.6.36 -> 2.6.37 From: Dave Airlie To: Linus Torvalds Cc: Keith Packard , Carlos Mafra , Dave Airlie , "Rafael J. Wysocki" , Takashi Iwai , Linux Kernel Mailing List , Maciej Rutecki , Florian Mickler , Andrew Morton , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 24 On Fri, Feb 4, 2011 at 11:11 AM, Linus Torvalds wrote: > On Thu, Feb 3, 2011 at 5:05 PM, Keith Packard wrote: >> >> The goal is to make it so that when you *do* set a mode, DPMS gets set >> to ON (as the monitor will actually be "on" at that point). Here's a >> patch which does the DPMS_ON precisely when setting a mode. > > Ok, patch looks sane, but it does leave me with the "what about the > 'fb_changed' case?" question. Is that case basically guaranteed to not > change any existing dpms state? Yes its inconsistent behaviour but nothing in the fb_changed case will affect the DPMS state. I expect we should probably do that so all paths via that function turn DPMS on, and it'll be consistent, might be something for 39. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/