Date: Fri, 4 Feb 2011 23:00:07 +0100
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: John Villalovos <jvillalo@redhat.com>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "John L. Villalovos" <john.l.villalovos@intel.com>, prarit@redhat.com
Subject: Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique
Message-ID: <20110204220007.GA6052@elte.hu>
References: <20110204174831.GA10370@intel-s3eb1-02.lab.bos.redhat.com>
 <4D4C4C4D.40106@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D4C4C4D.40106@zytor.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 27


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 02/04/2011 09:48 AM, John Villalovos wrote:
> > x86, apic: Make "broken BIOS!!" messages unique
> > 
> > There are five identical "broken BIOS!!" messages.  This patch makes each
> > message unique so that it is easier to determine which message was actually
> > printed.
> > 
> > The 'inconceivable' messages are because it should not be possible to reach
> > those code paths.
> 
> How about labelling these "MPBIOS" or so, too?

Yeah.

Also, the messages do not need to shout i suspect - the '!!' can be removed as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/