Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663Ab1BFHa4 (ORCPT ); Sun, 6 Feb 2011 02:30:56 -0500 Received: from terminus.zytor.com ([198.137.202.10]:53104 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414Ab1BFHaz (ORCPT ); Sun, 6 Feb 2011 02:30:55 -0500 Message-ID: <4D4E4E0D.2080806@zytor.com> Date: Sat, 05 Feb 2011 23:30:21 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Yinghai Lu CC: Jeremy Fitzhardinge , Stefano Stabellini , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "x86@kernel.org" , Konrad Rzeszutek Wilk , Jan Beulich Subject: Re: [PATCH] x86/mm/init: respect memblock reserved regions when destroying mappings References: <4D4A3782.3050702@zytor.com> <4D4ADFAD.7060507@zytor.com> <4D4CA568.70907@goop.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 20 On 02/05/2011 11:02 PM, Yinghai Lu wrote: > why not just move calling cleanup_highmap down? > > something like attached patch. This patch looks very clean and looks on the surface of it like it is removing some ugly ad hoc code, but (as always) it needs a description about the problem it solves and why it is correct. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/