Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511Ab1BGJdx (ORCPT ); Mon, 7 Feb 2011 04:33:53 -0500 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:53959 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312Ab1BGJdw (ORCPT ); Mon, 7 Feb 2011 04:33:52 -0500 Message-ID: <4D4FBC79.5070602@linux.vnet.ibm.com> Date: Mon, 07 Feb 2011 15:03:45 +0530 From: Ciju Rajan K User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Peter Zijlstra CC: Satoru Takeuchi , linux kernel mailing list , Bharata B Rao , Ingo Molnar , Srivatsa Vaddagiri , Ciju Rajan K Subject: Re: [PATCH 1/2 v2.0]sched: Removing unused fields from /proc/schedstat References: <4D3F3595.4020607@linux.vnet.ibm.com> <4D3F3676.1030601@linux.vnet.ibm.com> <4D3FBAD5.1070307@jp.fujitsu.com> <4D463647.7000106@linux.vnet.ibm.com> <4D491BE2.7010802@linux.vnet.ibm.com> <4D4A731E.5030401@jp.fujitsu.com> In-Reply-To: <4D4A731E.5030401@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2787 Lines: 82 Hi Peter, Could you please consider this patch set for inclusion? -Ciju On 02/03/2011 02:49 PM, Satoru Takeuchi wrote: > Hi Ciju, > > (2011/02/02 17:54), Ciju Rajan K wrote: >> Hi Satoru, >> >> >>>> I think we can remove rq->sched_switch and rq->sched_switch >>>> without no problem because they are meaningless. The former >>>> is for old O(1) scheduler and means the number of runqueue >>>> switching among active/expired queue. The latter is for >>>> SD_WAKE_BALANCE flag and its logic is already gone. >>>> >>>> However sbe_* are for SD_BALANCE_EXEC flag and sbf_* are for >>>> SD_BALANCE_FORK flag. Since both logic for them are still alive, >>>> the absence of these accounting is regression in my perspective. >>>> In addition, these fields would be useful for analyzing load >>>> balance behavior. >>>> >> >> The sbe_*& sbf_* counters were added by the commit >> 68767a0ae428801649d510d9a65bb71feed44dd1 But it was subsequently >> removed by the commit 476d139c218e44e045e4bc6d4cc02b010b343939 > > OK, I understood. It's OK if user tools referring /proc/schedstat > are released sync with this change. > > I confirmed the following: > > - This patch removes some unused schedstat fields and related > data. > - The kernel applying this patch works fine on my i386 box. > > Tested-by: Satoru Takeuchi > > Thanks, > Satoru > >> >> [ciju@ciju kernel]$ git describe 68767a0ae428801649d510d9a65bb71feed44dd1 --contains >> v2.6.13-rc1~68^2~148 >> [ciju@ciju kernel]$ git describe 476d139c218e44e045e4bc6d4cc02b010b343939 --contains >> v2.6.13-rc1~68^2~140 >> >> So.. it was introduced and removed in 2.6.13 time frame >> >> >> When the counters were removed the sbe_* sbf_* variable >> declarations were not removed. Hence it caused a little confusion. >> So I believe these stats were not available and hence can't be >> considered as regression. >> >> 476d139c218e44e045e4bc6d4cc02b010b343939 consolidated the fork and >> exec balance. Thereafter it became non-trivial to provide separate >> stats for fork and exec events. So if people think a consolidated >> balance-on-event is needed, it can be looked into separately. But >> that shouldn't prevent this documentation cleanup patch from >> getting in. >> >> -Ciju >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/