Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059Ab1BGKKU (ORCPT ); Mon, 7 Feb 2011 05:10:20 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:63940 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352Ab1BGKKS convert rfc822-to-8bit (ORCPT ); Mon, 7 Feb 2011 05:10:18 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=neNp+HXWTS6KXGzQySgniuvoCerXTBFknler/pNh/85Wb+LbtrKGxDHLMlbIkimQa8 bEejsLsw3sY6vVhNDAnItUmOZU/2sYH5JwM7ocEM4+oEhHsr2WbCFkaMk9dDl7MbNnoH KwR/fzsPufy9LNmhQ9R9PWLfXqLi0FzRjxjJE= MIME-Version: 1.0 In-Reply-To: <201102062107.49909.rjw@sisk.pl> References: <201102061519.11360.rjw@sisk.pl> <201102062106.29712.rjw@sisk.pl> <201102062107.49909.rjw@sisk.pl> Date: Mon, 7 Feb 2011 19:10:18 +0900 Message-ID: Subject: Re: [PATCH 1/2] USB / Hub: Do not call device_set_wakeup_capable() under spinlock From: Minchan Kim To: "Rafael J. Wysocki" Cc: Alan Stern , LKML , Linux PM mailing list , Greg KH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 23 On Mon, Feb 7, 2011 at 5:07 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > A subsequent patch will modify device_set_wakeup_capable() in such > a way that it will call functions which may sleep and therefore it > shouldn't be called under spinlocks.  In preparation for that, modify > usb_set_device_state() to avoid calling device_set_wakeup_capable() > under device_state_lock. > > Signed-off-by: Rafael J. Wysocki > Acked-by: Greg Kroah-Hartman Reported-by: Minchan Kim Tested-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/