DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=abaCJmTr99xre+6Pj+13dVA++XukrSGpneH4mRSxei7P66eKrWTahIunGJjcxJGjSw
         nl7v9KTQdS3OAyi15NMF5T3J/LWXPyvKpIF5+G7SxCSwjFK3+bREcg5+o5X8k4PxO3dl
         OEdaJYDKD5ItvjtxbjWd3Hfa21eGlKknRaQSM=
MIME-Version: 1.0
In-Reply-To: <4D4FE1D6.5050507@ru.mvista.com>
References: <201102071153.37633.bzolnier@gmail.com>
	<4D4FE1D6.5050507@ru.mvista.com>
Date: Mon, 7 Feb 2011 13:58:47 +0100
Message-ID: <AANLkTikjwjvHXMqYaVpHH3pkxM-Uo_C+kn0DLY2NfTzi@mail.gmail.com>
Subject: Re: [PATCH] ide: legacy VLB drivers housekeeping
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2378
Lines: 68

On Mon, Feb 7, 2011 at 1:13 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.

Hi,

> On 07-02-2011 13:53, Bartlomiej Zolnierkiewicz wrote:
>
>> * remove stale documentation
>> * remove dead ALWAYS_SET_DTC2278_PIO_MODE code from dtc2278
>> * remove legacy debugging code from ht6560b
>
>> There should be no functional changes caused by this patch.
>
>> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
>
> [...]
>
>> Index: b/drivers/ide/ali14xx.c
>> ===================================================================
>> --- a/drivers/ide/ali14xx.c
>> +++ b/drivers/ide/ali14xx.c
>> @@ -7,32 +7,7 @@
>> ? *
>> ? * Works for ALI M1439/1443/1445/1487/1489 chipsets.
>> ? *
>> - * Adapted from code developed by derekn@vw.ece.cmu.edu. ?-ml
>> - * Derek's notes follow:
>> - *
>> - * I think the code should be pretty understandable,
>> - * but I'll be happy to (try to) answer questions.
>> - *
>> - * The critical part is in the setupDrive function. ?The initRegisters
>> - * function doesn't seem to be necessary, but the DOS driver does it, so
>> - * I threw it in.
>> - *
>> - * I've only tested this on my system, which only has one disk. ?I posted
>> - * it to comp.sys.linux.hardware, so maybe some other people will try it
>> - * out.
>> - *
>> - * Derek Noonburg ?(derekn@ece.cmu.edu)
>> - * 95-sep-26
>> - *
>> - * Update 96-jul-13:
>> - *
>> - * I've since upgraded to two disks and a CD-ROM, with no trouble, and
>> - * I've also heard from several others who have used it successfully.
>> - * This driver appears to work with both the 1443/1445 and the 1487/1489
>> - * chipsets. ?I've added support for PIO mode 4 for the 1487. ?This
>> - * seems to work just fine on the 1443 also, although I'm not sure it's
>> - * advertised as supporting mode 4. ?(I've been running a WDC AC21200 in
>> - * mode 4 for a while now with no trouble.) ?-Derek
>> + * Adapted from code developed by Derek Noonburg<derekn@vw.ece.cmu.edu>.
>> ?-
>> ml
>
> ? The patch is line-wrapped...

[...]

> ? And above...

Sorry for that,  I somehow managed to not notice it until now..
(ah, the joys of fresh OS installation)..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/