Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755047Ab1BGV41 (ORCPT ); Mon, 7 Feb 2011 16:56:27 -0500 Received: from claw.goop.org ([74.207.240.146]:36051 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755000Ab1BGV40 (ORCPT ); Mon, 7 Feb 2011 16:56:26 -0500 Message-ID: <4D506A85.9030802@goop.org> Date: Mon, 07 Feb 2011 13:56:21 -0800 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: Yinghai Lu CC: Stefano Stabellini , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "x86@kernel.org" , Konrad Rzeszutek Wilk , Jan Beulich Subject: Re: [PATCH] x86/mm/init: respect memblock reserved regions when destroying mappings References: <4D4A3782.3050702@zytor.com> <4D4ADFAD.7060507@zytor.com> <4D4CA568.70907@goop.org> <4D4E4E0D.2080806@zytor.com> <4D4EF553.6000000@kernel.org> <4D50343E.1020906@kernel.org> <4D504161.2060900@kernel.org> In-Reply-To: <4D504161.2060900@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1885 Lines: 42 On 02/07/2011 11:00 AM, Yinghai Lu wrote: > On 02/07/2011 10:58 AM, Stefano Stabellini wrote: >> On Mon, 7 Feb 2011, Yinghai Lu wrote: >>> On 02/07/2011 08:50 AM, Stefano Stabellini wrote: >>>> On Sun, 6 Feb 2011, Yinghai Lu wrote: >>>>> On 02/05/2011 11:30 PM, H. Peter Anvin wrote: >>>>>> On 02/05/2011 11:02 PM, Yinghai Lu wrote: >>>>>>> why not just move calling cleanup_highmap down? >>>>>>> >>>>>>> something like attached patch. >>>>>> This patch looks very clean and looks on the surface of it like it is >>>>>> removing some ugly ad hoc code, but (as always) it needs a description >>>>>> about the problem it solves and why it is correct. >>>>> Sure. >>>>> >>>>> >>>>> Jeremy and xen guys, can you please check if it works well with xen ? >>>>> >>>> Actually this patch makes things worse on xen, because before >>>> cleanup_highmap() wasn't called at all on xen (on purpose) and now it >>>> is, fully destroying all the mappings we have at _end. >>>> >>>> Can we add a check on memblock reserved regions in cleanup_highmap()? >>>> Otherwise could we avoid calling cleanup_highmap() at all on xen? >>> why DO xen need over-mapped kernel initial mapping? >>> >>> what is in that range after _end to 512M? >> The mfn list that is the list of machine frame numbers assigned to this >> domain; it is used across the kernel to convert pfns into mfns. >> It passed to us at that address by the domain builder. > is it possible for you to pass physical address, and then map it in kernel? That is possible in principle, but very difficult in practice. What's wrong with honouring reserved memory ranges under all circumstances? J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/