Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752438Ab1BHJUG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Feb 2011 04:20:06 -0500
Received: from bombadil.infradead.org ([18.85.46.34]:50600 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751253Ab1BHJUE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Feb 2011 04:20:04 -0500
Subject: Re: RFC: /proc/<pid>/sched should contain cumulative data for all
 threads in process
From: Peter Zijlstra <peterz@infradead.org>
To: Chris Friesen <chris.friesen@genband.com>
Cc: Ingo Molnar <mingo@elte.hu>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <4D50723B.7020400@genband.com>
References: <4D50723B.7020400@genband.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 08 Feb 2011 10:21:05 +0100
Message-ID: <1297156865.13327.57.camel@laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1199
Lines: 27

On Mon, 2011-02-07 at 16:29 -0600, Chris Friesen wrote:
> Hi,
> 
> We've got a tool that gathers lots of scheduling data for each process
> (not task/thread) on the system.
> 
> For /proc/<pid>/{stat,io} this is straightforward, as the per-thread
> values are summed together for the process as a whole.
> 
> However, /proc/<pid>/sched only shows the data for the individual thread
> with the same tid as the pid.  To get a per-process view we need to
> manually scan all the threads and sum them--and this can get expensive
> due to all the extra file operations, parsing, etc.
> 
> Was this a concious design decision, or just an oversight?  Would a
> patch converting it to whole-process values be accepted or is it enough
> of a standard interface that we can't break existing apps that expect
> the current behaviour?

I'd as soon remove all that stuff than extend it, its an abi liability,
esp since you're talking about tools parsing this stuff.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/