Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290Ab1BHK3M (ORCPT ); Tue, 8 Feb 2011 05:29:12 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:61441 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789Ab1BHK3J (ORCPT ); Tue, 8 Feb 2011 05:29:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Vb4FNgXw0NrGtul8JD9PzeeXAL9ZpSt5sG7YTshpqlCayf/QmfsSeMmFbu169ygPLH b9jAlKdICSOd1AJ4CMKoDxLQcwd5IPo28Q4s+Y1EcOxdhBHZoyBTQT3xpLK6bgbRwbil N+61Kuz5ypkrYEca1oCTphierTJvKnK/Q6heI= MIME-Version: 1.0 In-Reply-To: <4D50E4DD.4030500@samsung.com> References: <20101208115510.GD10998@console-pimps.org> <20101209064751.GA21128@void.printf.net> <20101209160157.GA28586@void.printf.net> <20101211192320.GA24430@void.printf.net> <4D354752.3030401@samsung.com> <4D50E4DD.4030500@samsung.com> Date: Tue, 8 Feb 2011 10:29:06 +0000 Message-ID: Subject: Re: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver. From: Will Newton To: Jaehoon Chung Cc: Chris Ball , Linux Kernel list , linux-mmc@vger.kernel.org, Matt Fleming , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 25 On Tue, Feb 8, 2011 at 6:38 AM, Jaehoon Chung wrote: > Hi Will.. > > I need your help for your code.. > > In dw_mmc.h, exist some function pointer.. > > int *get_ro(u32 slot_id); > int *get_cd(u32 slot_id); > ... > > Just only need slot_id?? > If i need the "struct dw_mci", could i append the parameter? Yes, that should be possible. However I would like to reduce the number of places the whole struct dw_mci is passed around if possible, as the whole struct is usually not needed and it exposes some driver internals. Which part of struct dw_mci do you need in the callback? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/